Revised request should use HRID not UUID - #675
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the “accept-retry” (revised request) flow so that the newly created retry patron request uses a requester-derived HRID (via GetNextHrid) instead of a random UUID, aligning retry request identifiers with the existing HRID-based request creation behavior.
Changes:
- Generate retry patron request IDs using
PrRepo.GetNextHrid(ctx, requesterSymbol)(derived fromRequesterSymbol) rather thanuuid.NewString(). - Ensure the retry request’s
ID,RequesterReqID, and ISO18626RequestingAgencyRequestIdare all set consistently to the generated HRID. - Update API/service tests to assert the new retry ID format (requester HRID prefix) and to support/verify HRID generation in mocks.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| broker/patron_request/service/action.go | Switches retry request ID generation from UUID to requester HRID via GetNextHrid. |
| broker/patron_request/service/action_test.go | Extends the repo mock with GetNextHrid and asserts the retry request IDs/headers match the generated HRID. |
| broker/test/patron_request/api/api-handler_test.go | Integration test now asserts the cloned retry request ID uses the requester HRID prefix. |
adamdickmeiss
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.